Skip to content

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 10, 2025

Description of Change

Since the input size of postfix_evaluation is a template parameter, this function needs to be compile for every used input size (this increases both the build time and the size of the binary).

This PR changes the the type of the input to std::vector to avoid such problem.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Use std::vector as input type, to avoid increase of build time and binary size.

@vil02 vil02 marked this pull request as ready for review September 10, 2025 13:12
@vil02 vil02 force-pushed the use_vector_as_input_of_postfix_evaluation branch from 0c851e0 to ad60004 Compare September 25, 2025 06:37
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@realstealthninja realstealthninja merged commit 07663b0 into TheAlgorithms:master Sep 25, 2025
6 of 7 checks passed
@vil02 vil02 deleted the use_vector_as_input_of_postfix_evaluation branch September 25, 2025 07:34
realstealthninja pushed a commit to realstealthninja/C-Plus-Plus that referenced this pull request Oct 1, 2025
realstealthninja added a commit to realstealthninja/C-Plus-Plus that referenced this pull request Oct 1, 2025
realstealthninja added a commit to realstealthninja/C-Plus-Plus that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants